Skip to content

chore(deps): update @primer/react to v37 #1746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): update @primer/react to v37 #1746

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 20, 2025 •
edited
Loading

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@primer/react 36.27.0 -> 37.25.0 age adoption passing confidence

Release Notes

primer/react (@​primer/react)

v37.25.0

Compare Source

Minor Changes
Patch Changes

v37.24.0

Compare Source

Minor Changes
Patch Changes

v37.23.0

Compare Source

Minor Changes
Patch Changes

v37.22.0

Compare Source

Minor Changes
Patch Changes

v37.21.0

Compare Source

Minor Changes
Patch Changes

v37.20.0

Compare Source

Minor Changes
Patch Changes

v37.19.1

Compare Source

Patch Changes

  • Update data table pagination pageEnd to handle zero based index

  • b926c08 Thanks @​AAugustine! - Update data table pagination pageEnd to handle zero based index

v37.19.0

Compare Source

Minor Changes
Patch Changes

v37.18.0

Compare Source

Permalink to documentation
Minor Changes
Patch Changes

v37.17.0

Compare Source

Minor Changes
Patch Changes

v37.16.0

Compare Source

Minor Changes
Patch Changes

v37.15.0

Compare Source

Minor Changes
Patch Changes

v37.14.0

Compare Source

Minor Changes
Patch Changes

v37.13.0

Compare Source

Minor Changes
Patch Changes

v37.12.0

Compare Source

Permalink to documentation
Minor Changes
Patch Changes

Configuration

📅 Schedule: Branch creation - Between 12:00 AM and 03:59 AM, only on Monday ( * 0-3 * * 1 ) (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependency Dependency updates label Jan 20, 2025
setchy
setchy requested changes Jan 20, 2025
View reviewed changes
Copy link
Member

@setchy setchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When bringing Primer React into your project you will need a bundler setup to be aware of how to handle CSS when imported from a JavaScript context.

See primer/react#5165

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@setchy setchy requested a review from afonsojramos February 6, 2025 15:58
@renovate renovate bot force-pushed the renovate/primer-react-37.x branch 4 times, most recently from e637a16 to 5c548bd Compare February 13, 2025 23:33
@renovate renovate bot force-pushed the renovate/primer-react-37.x branch 5 times, most recently from d03e23d to 0725eb4 Compare February 21, 2025 19:09
@renovate renovate bot force-pushed the renovate/primer-react-37.x branch 4 times, most recently from b3620d6 to 015d1a4 Compare March 4, 2025 13:37
@renovate renovate bot force-pushed the renovate/primer-react-37.x branch 3 times, most recently from 80be4f2 to 5b506d1 Compare March 8, 2025 13:47
@renovate renovate bot force-pushed the renovate/primer-react-37.x branch 5 times, most recently from 3416e68 to 51da6e3 Compare March 20, 2025 12:17
@renovate renovate bot force-pushed the renovate/primer-react-37.x branch 3 times, most recently from b156bff to eb959b4 Compare May 5, 2025 22:34
@renovate renovate bot force-pushed the renovate/primer-react-37.x branch 7 times, most recently from ff85be7 to 6719750 Compare May 13, 2025 02:43
@renovate renovate bot force-pushed the renovate/primer-react-37.x branch 4 times, most recently from 0d69d4f to 85c9941 Compare May 17, 2025 08:11
@setchy setchy added help-wanted Extra attention is needed blocked Is blocked by another issue or dependency labels May 17, 2025
@renovate renovate bot force-pushed the renovate/primer-react-37.x branch 3 times, most recently from c70b82f to 9502fda Compare May 26, 2025 12:01
@SiriusCrain
Copy link
Contributor

@setchy do you need help with this too?

@setchy
Copy link
Member

setchy commented May 27, 2025

@setchy do you need help with this too?

Help would be great. I've had a few timeboxed attempts. The experimental primer Banner component is giving some headaches

@SiriusCrain
Copy link
Contributor

@setchy do you need help with this too?

Help would be great. I've had a few timeboxed attempts. The experimental primer Banner component is giving some headaches

Do we use some component which need to be replaced with Banner, or they implemented some breaking changes?

@setchy
Copy link
Member

setchy commented May 27, 2025

primer v37 triggers these compilation issues when using the experimental components. My guess is it may be an upstream change

Error: src/renderer/components/settings/SettingsReset.tsx(4,24): error TS2307: Cannot find module '@primer/react/experimental' or its corresponding type declarations.
  There are types at '/Users/runner/work/gitify/gitify/node_modules/@primer/react/lib-esm/experimental/index.d.ts', but this result could not be resolved under your current 'moduleResolution' setting. Consider updating to 'node16', 'nodenext', or 'bundler'.
Error: src/renderer/routes/LoginWithOAuthApp.tsx(19,24): error TS2307: Cannot find module '@primer/react/experimental' or its corresponding type declarations.
  There are types at '/Users/runner/work/gitify/gitify/node_modules/@primer/react/lib-esm/experimental/index.d.ts', but this result could not be resolved under your current 'moduleResolution' setting. Consider updating to 'node16', 'nodenext', or 'bundler'.
Error: src/renderer/routes/LoginWithPersonalAccessToken.tsx(19,24): error TS2307: Cannot find module '@primer/react/experimental' or its corresponding type declarations.
  There are types at '/Users/runner/work/gitify/gitify/node_modules/@primer/react/lib-esm/experimental/index.d.ts', but this result could not be resolved under your current 'moduleResolution' setting. Consider updating to 'node16', 'nodenext', or 'bundler'.

@SiriusCrain
Copy link
Contributor

primer v37 triggers these compilation issues when using the experimental components. My guess is it may be an upstream change

Error: src/renderer/components/settings/SettingsReset.tsx(4,24): error TS2307: Cannot find module '@primer/react/experimental' or its corresponding type declarations.
  There are types at '/Users/runner/work/gitify/gitify/node_modules/@primer/react/lib-esm/experimental/index.d.ts', but this result could not be resolved under your current 'moduleResolution' setting. Consider updating to 'node16', 'nodenext', or 'bundler'.
Error: src/renderer/routes/LoginWithOAuthApp.tsx(19,24): error TS2307: Cannot find module '@primer/react/experimental' or its corresponding type declarations.
  There are types at '/Users/runner/work/gitify/gitify/node_modules/@primer/react/lib-esm/experimental/index.d.ts', but this result could not be resolved under your current 'moduleResolution' setting. Consider updating to 'node16', 'nodenext', or 'bundler'.
Error: src/renderer/routes/LoginWithPersonalAccessToken.tsx(19,24): error TS2307: Cannot find module '@primer/react/experimental' or its corresponding type declarations.
  There are types at '/Users/runner/work/gitify/gitify/node_modules/@primer/react/lib-esm/experimental/index.d.ts', but this result could not be resolved under your current 'moduleResolution' setting. Consider updating to 'node16', 'nodenext', or 'bundler'.

Thank you for clarification, I will check

@renovate renovate bot force-pushed the renovate/primer-react-37.x branch 2 times, most recently from 617e8f8 to 1f7a2df Compare May 28, 2025 20:08
@renovate renovate bot force-pushed the renovate/primer-react-37.x branch from 1f7a2df to 0327469 Compare May 29, 2025 16:36
@SiriusCrain
Copy link
Contributor

@setchy I checked it.

  1. experimental path was fixed by changing both module and moduleResolution to 'nodenext'
  2. They are moving away from styled-components in favor of CSS Modules, so probably styling and self-written components will require refactoring.
  3. Self-written components like Tooltip currently breaking the app, so I will try to fix/rewrite them, or adapt similar components from premier

What do you think about it?

@SiriusCrain
Copy link
Contributor

SiriusCrain commented May 29, 2025 •
edited
Loading

@setchy I checked it.

  1. experimental path was fixed by changing both module and moduleResolution to 'nodenext'
  2. They are moving away from styled-components in favor of CSS Modules, so probably styling and self-written components will require refactoring.
  3. Self-written components like Tooltip currently breaking the app, so I will try to fix/rewrite them, or adapt similar components from premier

What do you think about it?

Nevermind, it was not because of self written tooltip, I almost fixed it and will push later, need some time to test locally and investigate strange issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@setchy setchy setchy requested changes

@bmulholland bmulholland Awaiting requested review from bmulholland bmulholland is a code owner

@afonsojramos afonsojramos Awaiting requested review from afonsojramos afonsojramos is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@afonsojramos afonsojramos

Labels
blocked Is blocked by another issue or dependency dependency Dependency updates help-wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SiriusCrain @setchy @afonsojramos